Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean download_and_extract() function #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean download_and_extract() function #30

wants to merge 1 commit into from
+3 −5

Conversation

ishaan-mehta
Copy link
Contributor

@ishaan-mehta ishaan-mehta commented Oct 24, 2021 •
edited
Loading

Get rid of unused variable fn
Use with statement instead of try/finally to open tarball

@ishaan-mehta
Clean download_and_extract() function
2349994 
Get rid of unused variable "fn"
Use "with" statement instead of "try"/"finally" to open tar file
@ishaan-mehta
Copy link
Contributor Author

ishaan-mehta commented Apr 21, 2022 •
edited
Loading

@classicsong @mufeili
Would you like to take a look here? Just updating to clean it up a bit and use best practice for opening Python files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ishaan-mehta