Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add spacing, remove test blog, fix syntax #32

Merged
merged 9 commits into from
Oct 20, 2023
Merged

fix: add spacing, remove test blog, fix syntax #32

merged 9 commits into from
Oct 20, 2023

Conversation

waymobetta
Copy link
Contributor

@waymobetta waymobetta commented Oct 6, 2023

This PR introduces the following:

  • removes test blog post
  • adds spacing around image within blog post
  • fixes markdown syntax
  • fixes tag (URL rendering formatting)

@waymobetta waymobetta self-assigned this Oct 6, 2023
@waymobetta
Copy link
Contributor Author

The proposed fix for adding spacing around the image is not ideal (using excessive </br> though I couldn't figure out a better way to do this; adding padding to the div via a style attribute seemed like a good idea but it wasn't rendering. Also markdown renders differently in VS Code vs. Github, something to note.

@waymobetta waymobetta marked this pull request as ready for review October 6, 2023 17:42
@waymobetta waymobetta marked this pull request as draft October 6, 2023 17:43
@waymobetta waymobetta marked this pull request as ready for review October 6, 2023 17:46
@waymobetta waymobetta marked this pull request as draft October 6, 2023 17:46
@waymobetta
Copy link
Contributor Author

Apologies if duplicate review emails were sent; I was testing the draft<>ready for review functionality.

@waymobetta
Copy link
Contributor Author

Currently looking into how the tag at the footer of the blog post gets rendered and where this tag is managed; it looks to be realm functionality that adds this path in.

Screenshot 2023-10-06 at 10 52 03 AM

@leohhhn leohhhn self-requested a review October 6, 2023 18:45
@moul
Copy link
Member

moul commented Oct 10, 2023

Currently looking into how the tag at the footer of the blog post gets rendered and where this tag is managed; it looks to be realm functionality that adds this path in.

Tags should not contain spaces; they should be formatted like hashtags.

@waymobetta waymobetta marked this pull request as ready for review October 10, 2023 19:20
@waymobetta waymobetta requested a review from moul October 10, 2023 19:20
@moul moul merged commit ad7f1a0 into main Oct 20, 2023
1 check passed
@moul moul deleted the wmb-fixes branch October 20, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants