Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stdlibs/std)!: remove Get prefixes, extend abbreviations #3374

Merged
merged 64 commits into from
Feb 19, 2025

Conversation

hthieu1110
Copy link
Contributor

@hthieu1110 hthieu1110 commented Dec 19, 2024

Linked to #1475

  • GetCallerAt =>CallerAt
  • GetOrigSend => OriginSend
  • origSend => originSend
  • GetOrigCaller => OriginCaller
  • origCaller => originCaller
  • Orig => Origin
  • Addr => Address
  • PrevRealm => PreviousRealm
  • GetChainID => ChainID
  • GetBanker => NewBanker
  • GetChainDomain => ChainDomain
  • GetHeight => Height

BREAKING CHANGE: changes many of the existing standard library functions.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Dec 19, 2024
@Gno2D2 Gno2D2 requested review from a team December 19, 2024 14:31
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 19, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: hthieu1110/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes to 'docs' folder must be reviewed/authored by at least one devrel and one tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^docs/ (filename: docs/assets/how-to-guides/creating-grc20/mytoken-1.gno)

Then

🟢 Requirement satisfied
└── 🟢 And
    ├── 🟢 Or
    │   ├── 🔴 Pull request author is a member of the team: tech-staff
    │   └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request(with state "APPROVED")
    └── 🟢 Or
        ├── 🔴 Pull request author is a member of the team: devrels
        └── 🟢 At least 1 user(s) of the team devrels reviewed pull request(with state "APPROVED")

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🟢 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/tests/stdlibs/std/std.go 40.00% 6 Missing ⚠️
gnovm/stdlibs/std/banker.go 0.00% 5 Missing ⚠️
gnovm/stdlibs/std/native.go 72.22% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@hthieu1110 hthieu1110 marked this pull request as ready for review December 19, 2024 16:01
@hthieu1110 hthieu1110 changed the title feat(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller Dec 20, 2024
@hthieu1110 hthieu1110 changed the title refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller refactor(gnovm): remove Get prefixes from GetCallerAt, GetOrigSend, GetOrigCaller and extend abbreviations Dec 20, 2024
@jefft0 jefft0 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Dec 20, 2024
@Kouteki Kouteki requested review from petar-dambovaliev and mvertes and removed request for a team December 20, 2024 12:07
@Kouteki Kouteki added this to the 🚀 Mainnet beta launch milestone Dec 20, 2024
@Kouteki Kouteki removed the request for review from a team January 22, 2025 14:16
@Gno2D2 Gno2D2 requested a review from a team January 27, 2025 13:35
@Kouteki Kouteki removed the in focus label Feb 3, 2025
@zivkovicmilos
Copy link
Member

@hthieu1110
Please check the CI 🙏

@Kouteki
Copy link
Contributor

Kouteki commented Feb 17, 2025

Blocker: @zivkovicmilos to update the Protal Loop in order to accomodate the breaking changes.

@zivkovicmilos zivkovicmilos removed the don't merge Please don't merge this functionality temporarily label Feb 19, 2025
@zivkovicmilos
Copy link
Member

Coordinating PL changes with @sw360cab now 🫡
gnolang/tx-exports#39

@zivkovicmilos zivkovicmilos merged commit 0a239e1 into gnolang:master Feb 19, 2025
69 checks passed
notJoon added a commit to gnoverse/tlin that referenced this pull request Feb 19, 2025
# Description

to support this change
gnolang/gno#3374 (comment)

## Changes

Added a new data structure `PkgTypeMethodMap` to store deprecated
methods by package, type, and method name
Implemented `RegisterMethod` function to register deprecated methods
jeronimoalbi added a commit that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Functionality that contains breaking changes 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Development

Successfully merging this pull request may close these issues.

9 participants