-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gnovm): protect TypedValue stringer against deep recursivity #3790
Conversation
The protectedStringer is improved by limiting the successive number of nested calls when constructing the string representation of a deeply recursive value. Fixes #3471.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Does this fail to create problems on-chain? |
This change will at least prevent high computing cost issues when calling It doesn't address possible high computing costs when marshalling/unmarshalling such kind of data, if it has to be persisted on chain. A possible solution to that could be to apply the same recursivity detection strategy at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it completely addressed #3471, but this fix LGTM.
The protectedStringer is improved by limiting the successive number of nested calls when constructing the string representation of a deeply recursive value.
Fixes #3471.