Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ser-kit to v2 #721

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 30, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
ser-kit 1.1.0 -> 2.0.0 age adoption passing confidence

Release Notes

gnosisguild/ser-kit (ser-kit)

v2.0.0

Compare Source

⚠ BREAKING CHANGES
  • formatPrefixedAddress renamed to prefixAddress
  • parsePrefixedAddress renamed to unprefixAddress
  • generally handle addresses in lowercase representation (#​35)
Bug Fixes
Miscellaneous Chores
  • formatPrefixedAddress renamed to prefixAddress (ea31896)
  • parsePrefixedAddress renamed to unprefixAddress (ea31896)

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zodiac-pilot-companion-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 2:46pm

Copy link

github-actions bot commented Jan 30, 2025

Coverage Report for deployables/extension

Status Category Percentage Covered / Total
🔵 Lines 63.67% 3350 / 5261
🔵 Statements 63.67% 3350 / 5261
🔵 Functions 70.4% 176 / 250
🔵 Branches 77.67% 421 / 542
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
deployables/extension/src/types.ts 100% 100% 100% 100%
deployables/extension/src/panel/integrations/safe/signing.ts 32.6% 100% 0% 32.6% 23-29, 34-37, 40-50, 53, 56-65
deployables/extension/src/panel/pages/$activeRouteId/transactions/RolePermissionCheck.tsx 25.56% 100% 0% 25.56% 26-80, 88-162
deployables/extension/src/panel/pages/$activeRouteId/transactions/Transactions.tsx 79.41% 88.88% 66.66% 79.41% 46-62, 158-175
deployables/extension/src/panel/pages/$activeRouteId/transactions/RouteBubble/index.tsx 96.51% 50% 50% 96.51% 105-107
deployables/extension/src/panel/pages/ConnectionStack/index.tsx 78.57% 50% 100% 78.57% 32-38
deployables/extension/src/panel/providers/isConnected.ts 11.76% 100% 0% 11.76% 5-22
deployables/extension/src/panel/providers-ui/ProvideProvider.tsx 46.51% 55.55% 66.66% 46.51% 38, 41, 52-69, 75-126, 132-141, 197-214
deployables/extension/src/panel/providers/fork-provider/translateSignSnapshotVote.ts 18.18% 100% 0% 18.18% 21-62
deployables/extension/src/panel/transactionTranslations/cowswapSetPreSignature.ts 50% 33.33% 100% 50% 47-48, 57-104
deployables/extension/src/panel/transactionTranslations/useApplicableTranslation.ts 71.77% 70% 85.71% 71.77% 35-61, 78, 90-95, 119-126
deployables/extension/src/panel/transactionTranslations/useGloballyApplicableTranslation.ts 55.11% 78.94% 83.33% 55.11% 29-71, 84-85, 91-95, 114-115, 129-135, 151-157
deployables/extension/src/panel/transactionTranslations/karpatkeyInstitutional/bridges.ts 99.3% 75% 100% 99.3% 21-22
deployables/extension/src/panel/transactionTranslations/karpatkeyInstitutional/kpkBridgeAware.ts 95.55% 85.71% 100% 95.55% 70-71, 80-81
Generated in workflow #1773 for commit 53f9c55 by the Vitest Coverage Report Action

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying zodiac-pilot-connect with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53f9c55
Status: ✅  Deploy successful!
Preview URL: https://4bb47267.zodiac-pilot.pages.dev
Branch Preview URL: https://renovate-ser-kit-2-x.zodiac-pilot.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jan 30, 2025

Deploying zodiac-pilot with  Cloudflare Pages  Cloudflare Pages

Latest commit: 53f9c55
Status: ✅  Deploy successful!
Preview URL: https://34eda447.zodiac-pilot-29m.pages.dev
Branch Preview URL: https://renovate-ser-kit-2-x.zodiac-pilot-29m.pages.dev

View logs

@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 74004d0 to e1a3dbf Compare January 30, 2025 12:47
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from e1a3dbf to 6de1b7d Compare January 30, 2025 16:10
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 6de1b7d to f0d0e98 Compare January 30, 2025 17:27
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from f0d0e98 to 1ec308c Compare January 30, 2025 21:29
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 1ec308c to 85cedd5 Compare January 31, 2025 01:02
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 85cedd5 to a1a4124 Compare January 31, 2025 04:22
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from a1a4124 to 489354d Compare January 31, 2025 15:09
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 489354d to 45a7e66 Compare February 1, 2025 20:36
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 45a7e66 to 8995ded Compare February 1, 2025 22:24
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 8995ded to b4ab007 Compare February 2, 2025 08:26
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from b4ab007 to 28855b4 Compare February 2, 2025 18:02
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 28855b4 to 3cf0ef6 Compare February 2, 2025 21:55
@renovate renovate bot force-pushed the renovate/ser-kit-2.x branch from 3cf0ef6 to 6b2a1cf Compare February 3, 2025 01:51
Copy link
Contributor Author

renovate bot commented Feb 3, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@frontendphil
Copy link
Member

@jfschwarz type check fails because the TransactionResult from ser-kit uses just Hex as the type for data. Should this also be Lowercase<Hex> inside ser-kit?

@frontendphil
Copy link
Member

Also, we might add an alias for unprefix called clipPrefix which is a bit more real english?

@jfschwarz
Copy link
Collaborator

@jfschwarz type check fails because the TransactionResult from ser-kit uses just Hex as the type for data. Should this also be Lowercase<Hex> inside ser-kit?

yea we could do that. although in practice data is never checksummed and we'll probably also not do equality checks on it. still wouldn't harm

@jfschwarz
Copy link
Collaborator

Also, we might add an alias for unprefix called clipPrefix which is a bit more real english?

chatgpt told me "unprefix" is correct English 😁

@frontendphil frontendphil enabled auto-merge (squash) February 5, 2025 14:47
@frontendphil frontendphil merged commit 63dc82d into main Feb 5, 2025
16 checks passed
@frontendphil frontendphil deleted the renovate/ser-kit-2.x branch February 5, 2025 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants