Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the isPermaLink attribute to false in the guid sub-element (#28860) #28863

Closed
wants to merge 3 commits into from
Closed

Set the isPermaLink attribute to false in the guid sub-element (#28860) #28863

wants to merge 3 commits into from

Commits on Jan 20, 2024

  1. Set the isPermaLink attribute to false in the guid sub-element (g… 

    …o-gitea#28860)

Our `guid` is not a valid URL so according to the RSS spec the
`isPermaLink` attribute needs to be set to `false`.

Example:
```diff
<item>
  <title>yardenshoham opened issue &lt;a href=&#34;https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2&#34;&gt;yardenshoham/test#2&lt;/a&gt;</title>
  <link>https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</link>
  <description>2#hey</description>
  <content:encoded><![CDATA[2#hey]]></content:encoded>
  <author>yardenshoham</author>
- <guid>355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
+ <guid isPermaLink="false">355: https://3000-yardenshoham-gitea-jqlxjixsez9.ws-us107.gitpod.io/yardenshoham/test/issues/2</guid>
  <pubDate>Tue, 16 Jan 2024 18:54:36 +0000</pubDate>
</item>
```

References:
-
https://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
- Fixes go-gitea#28734
- gorilla/feeds#78
- go-gitea#21550
- gorilla/feeds#107

Signed-off-by: Yarden Shoham <[email protected]>
    @yardenshoham
    yardenshoham committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0f20b83 View commit details
    Browse the repository at this point in the history

  2. Run make tidy

    @yardenshoham
    yardenshoham committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    45ed6e1 View commit details
    Browse the repository at this point in the history

  3. One more build

    @yardenshoham
    yardenshoham committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    2295c2f View commit details
    Browse the repository at this point in the history