Remove jQuery from the commit graph (except Fomantic) #30395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched to plain JavaScript - Tested the commit graph and it works as before Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
yardenshoham
added
the
type/refactoring
silverwind
reviewed
Apr 10, 2024
silverwind
reviewed
Apr 10, 2024
Co-authored-by: silverwind <[email protected]>
silverwind
approved these changes
Apr 10, 2024
GiteaBot
added
lgtm/need 1
delvh
reviewed
Apr 10, 2024
| graphContainer.addEventListener('mouseenter', (e) => { | ||
| if (e.target.matches('#rev-list li')) { | ||
| const flow = e.target.getAttribute('data-flow'); | ||
| if (flow === '0') return; |
There was a problem hiding this comment.
Apparently 👀:
Every attempt is made to convert the attribute's string value to a JavaScript value (this includes booleans, numbers, objects, arrays, and null). A string is only converted to a number if doing so doesn't change its representation (for example, the string "100" is converted to the number 100, but "1E02" and "100.000" are left as strings because their numeric value of 100 serializes to "100"). When a string starts with '{' or '[', then jQuery.parseJSON is used to parse it; it must follow valid JSON syntax including quoted property names. A string not parseable as a JavaScript value is not converted.
Co-authored-by: delvh <[email protected]>
lunny
approved these changes
Apr 12, 2024
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
delvh
approved these changes
Apr 12, 2024
GiteaBot
removed
the
reviewed/wait-merge
silverwind
added a commit
to silverwind/gitea
that referenced
this pull request
Apr 13, 2024
* origin/main: (1540 commits)
Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461)
Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387)
Avoid losing token when updating mirror settings (go-gitea#30429)
Fix label rendering (go-gitea#30456)
Add comment for ContainsRedirectURI about the exact match (go-gitea#30457)
Update JS and PY deps, lock eslint and related plugins (go-gitea#30452)
Refactor cache and disable go-chi cache (go-gitea#30417)
Fix admin notice view-detail (go-gitea#30450)
Fix mirror error when mirror repo is empty (go-gitea#30432)
Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451)
Lock a few tool dependencies to major versions (go-gitea#30439)
Fix commit status cache which missed target_url (go-gitea#30426)
Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395)
Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430)
Limit the max line length when parsing git grep output (go-gitea#30418)
Change the default maxPerPage for gitbucket (go-gitea#30392)
Fix the spacing issue in the Project view (go-gitea#30415)
Add commit status summary table to reduce query from commit status table (go-gitea#30223)
Split `issue edit` code from `repo-legacy.js` into its own file (go-gitea#30419)
Check the token's owner and repository when registering a runner (go-gitea#30406)
...
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 14, 2024
* giteaofficial/main: Fix JS error when opening to expanded code comment (go-gitea#30463) fix: Fix to delete cookie when AppSubURL is non-empty (go-gitea#30375) Add `interface{}` to `any` replacement to `make fmt`, exclude `*.pb.go` (go-gitea#30461) Fix network error when open/close organization/individual projects and redirect to project page (go-gitea#30387) Avoid losing token when updating mirror settings (go-gitea#30429) Fix label rendering (go-gitea#30456) Add comment for ContainsRedirectURI about the exact match (go-gitea#30457) Update JS and PY deps, lock eslint and related plugins (go-gitea#30452) Refactor cache and disable go-chi cache (go-gitea#30417) Fix admin notice view-detail (go-gitea#30450) Fix mirror error when mirror repo is empty (go-gitea#30432) Add `/public/assets/img/webpack` to ignore files again (go-gitea#30451) Lock a few tool dependencies to major versions (go-gitea#30439) Fix commit status cache which missed target_url (go-gitea#30426) Remove jQuery from the commit graph (except Fomantic) (go-gitea#30395) Fix rename branch 500 when the target branch is deleted but exist in database (go-gitea#30430) Limit the max line length when parsing git grep output (go-gitea#30418)
Merged
|
-> Fix repo graph JS #31377 |
silverwind
pushed a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo using JavaScript without jQuery