Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file tree to file view page #32721

Open
wants to merge 106 commits into
base: main
Choose a base branch
from
Open

Add file tree to file view page #32721

wants to merge 106 commits into from
+1,113 −116

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Dec 5, 2024 •
edited by lunny
Loading

Resolve #29328

This pull request introduces a file tree on the left side when reviewing files of a repository.

32721

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 5, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 5, 2024
@kerwin612 kerwin612 marked this pull request as draft December 5, 2024 02:38
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Dec 5, 2024
@yp05327 yp05327 added this to the 1.24.0 milestone Dec 5, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 5, 2024
@kerwin612 kerwin612 marked this pull request as ready for review December 5, 2024 06:34
wxiaoguang
wxiaoguang reviewed Dec 5, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 5, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Dec 5, 2024
View reviewed changes
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 5, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 5, 2024
@kerwin612 kerwin612 requested a review from wxiaoguang December 5, 2024 14:22
@lunny
Copy link
Member

lunny commented Dec 5, 2024 •
edited
Loading

1 Move the three buttons on top of the left tree when expanding and move to the right once folding.
图片

2 The expanding state should be stored to users' configuration or as a session value once changed.
3 It should be sorted so that folders should always be on top of files on the left tree.
图片

@wxiaoguang wxiaoguang marked this pull request as draft December 7, 2024 03:21
@kerwin612 kerwin612 force-pushed the add-file-tree-to-file-view-page branch from 7229b60 to 59e46d4 Compare December 13, 2024 06:30
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2024
@kerwin612 kerwin612 force-pushed the add-file-tree-to-file-view-page branch from e45940d to c4e7f0c Compare December 13, 2024 12:20
@lunny lunny requested a review from wxiaoguang February 24, 2025 18:47
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 25, 2025 •
edited
Loading

The JS code is not maintainable. It should refactor the JS code first.

For example: #33498 (comment)

@lunny lunny mentioned this pull request Feb 26, 2025
Closed
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 1, 2025 •
edited
Loading

Refactor the related "init" functions by the approach (data-global-init, data-global-click) in separate PRs, then this PR doesn't need to touch too much JS code.

This was referenced Mar 3, 2025
Merged
Closed
Merged
This was referenced Mar 3, 2025
Closed
Merged
@kerwin612 kerwin612 requested a review from wxiaoguang March 4, 2025 01:19
wxiaoguang
wxiaoguang reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitea could run under a subpath. You need to double check your code to make sure sub path works.

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 4, 2025 •
edited
Loading

Git filenames could contain leading and trailing spaces, then JS error

image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 4, 2025 •
edited
Loading

When click submodule item, the page jumps out to another page, then user loses the current page's tree state.

image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 4, 2025 •
edited
Loading

Still JS error when special chars in filenames.

image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Mar 4, 2025 •
edited
Loading

Unable to recover from network errors:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang requested changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/changelog Adds the changelog for a new Gitea version type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] File Tree For Preview Mode
5 participants
@kerwin612 @lunny @yp05327 @wxiaoguang @GiteaBot