-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gitea always use its internal config, ignore /etc/gitconfig
#33076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 2, 2025
pull-request-size
bot
added
the
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
label
Jan 2, 2025
wxiaoguang
changed the title
Make Gitea always use its internal config, ignore
Make Gitea always use its internal config, ignore Jan 2, 2025
/etc/git/config
/etc/gitconfig
wxiaoguang
commented
Jan 2, 2025
wxiaoguang
added
the
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
label
Jan 2, 2025
wxiaoguang
force-pushed
the
fix-git-global-config
branch
from
January 2, 2025 04:29
afa949f
to
0201e02
Compare
lunny
approved these changes
Jan 2, 2025
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 2, 2025
delvh
approved these changes
Jan 2, 2025
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 2, 2025
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 2, 2025
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Jan 2, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 6, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Fix dropdown menu header and mobile view (go-gitea#33108) workflow_dispatch use workflow from trigger branch (go-gitea#33098) [skip ci] Updated translations via Crowdin Trivial fixes (go-gitea#33103) Fix empty git repo handling logic (go-gitea#33101) Refactor legacy line-number and scroll code (go-gitea#33094) Use `Project-URL` metadata field to get a PyPI package's homepage URL (go-gitea#33089) Clean up legacy form CSS styles (go-gitea#33081) [skip ci] Updated translations via Crowdin add myself to maintainers (go-gitea#33088) Make Gitea always use its internal config, ignore `/etc/gitconfig` (go-gitea#33076) Fix "stop time tracking button" on navbar (go-gitea#33084) Fix bleve fuzziness search (go-gitea#33078) Try to fix ACME directory problem (go-gitea#33072) Refactor env var related code (go-gitea#33075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
pr/breaking
Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it!
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In history, Gitea could use the system config
/etc/gitconfig
because some users said that "they might put certNonceSeed in it"Actually, we shouldn't not use it, because it also causes conflicts (there are already some fixes like #28848)
To make the system clear, I think it's worth to introduce the breaking change: add
GIT_CONFIG_NOSYSTEM=1
to all git commands.For most users, nothing need to do.
If you have made changes to
/etc/gitconfig
to affect Gitea's behavior, you need to move these config options to Gitea's internal git config file, it is usually in Gitea's{AppDataPath}/home/.git
directory.