Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty git repo handling logic #33101

Merged
merged 2 commits into from
Jan 4, 2025
Merged

Fix empty git repo handling logic #33101

merged 2 commits into from
Jan 4, 2025

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jan 4, 2025 •
edited
Loading

Fix #33092

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 4, 2025
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 4, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jan 4, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 4, 2025
Closed
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 4, 2025
@wxiaoguang wxiaoguang merged commit 3d544a3 into go-gitea:main Jan 4, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 4, 2025
@wxiaoguang wxiaoguang added the backport/v1.23 This PR should be backported to Gitea 1.23 label Jan 4, 2025
@wxiaoguang wxiaoguang deleted the fix-repo-empty branch January 4, 2025 10:47
wxiaoguang added a commit to wxiaoguang/gitea that referenced this pull request Jan 4, 2025
@wxiaoguang
Fix empty git repo handling logic (go-gitea#33101)
411ce55 
Fix go-gitea#33092
@wxiaoguang wxiaoguang mentioned this pull request Jan 4, 2025
Merged
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! labels Jan 4, 2025
wxiaoguang added a commit that referenced this pull request Jan 5, 2025
@wxiaoguang
Fix empty git repo handling logic and fix mobile view (#33101) (#33102)
e637008 
Backport #33101 and UI fix from main (including #33108)
yp05327
yp05327 reviewed Jan 6, 2025
View reviewed changes
templates/repo/empty.tmpl
Comment on lines +20 to +21
{{else if .Repository.IsEmpty}}
<div class="ui segment center">{{ctx.Locale.Tr "repo.no_branch"}}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quick guide will not be displayed any more after creating a new repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

main: Fix repo empty guide #33114

1.23: together in Fix package error handling and npm meta and empty repo guide #33112

And added a test for the guide page to make sure it won't break again.

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 6, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6f15516 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix dropdown menu header and mobile view (go-gitea#33108)
  workflow_dispatch use workflow from trigger branch (go-gitea#33098)
  [skip ci] Updated translations via Crowdin
  Trivial fixes (go-gitea#33103)
  Fix empty git repo handling logic (go-gitea#33101)
  Refactor legacy line-number and scroll code (go-gitea#33094)
  Use `Project-URL` metadata field to get a PyPI package's homepage URL (go-gitea#33089)
  Clean up legacy form CSS styles (go-gitea#33081)
  [skip ci] Updated translations via Crowdin
  add myself to maintainers (go-gitea#33088)
  Make Gitea always use its internal config, ignore `/etc/gitconfig` (go-gitea#33076)
  Fix "stop time tracking button" on navbar (go-gitea#33084)
  Fix bleve fuzziness search (go-gitea#33078)
  Try to fix ACME directory problem (go-gitea#33072)
  Refactor env var related code (go-gitea#33075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yp05327 yp05327 yp05327 left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Repo page redirect infinitely
5 participants
@wxiaoguang @lunny @Zettat123 @yp05327 @GiteaBot