Fix auto concurrency cancellation skips commit status updates #33764
+51
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add missing commit status * conflicts with concurrency support
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
lunny
approved these changes
Mar 2, 2025
GiteaBot
added
lgtm/need 1
lunny
added a commit
that referenced
this pull request
Mar 4, 2025
Wait tomorrow's Golang version. Maybe wait backport of #33764 and #33744, #33789 --------- Co-authored-by: metiftikci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33763
Since this conflics with #32751 that is planned for Gitea v1.24, this might make more sense as a backport to 1.23 if considered. Had this change laying around, because I'm not on a branch with "auto concurrency" replaced by "concurrency".
A 1.23 backport that resolves the conflict is here https://github.com/go-gitea/gitea/compare/release/v1.23...ChristopherHX:gitea:fix-actions-commit-status-update-1-23?expand=1