Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor repo-issue.ts #33784

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Refactor repo-issue.ts #33784

merged 4 commits into from
Mar 4, 2025
+191 −233

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Mar 4, 2025 •
edited
Loading

And remove jQuery

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 4, 2025
@wxiaoguang
Copy link
Contributor Author

wxiaoguang commented Mar 4, 2025 •
edited
Loading

Diff by ignoring spaces: https://github.com/go-gitea/gitea/pull/33784/files?diff=split&w=1

Manually tested:

View command line instructions

image

Issue dependencies

image

image

Toggle WIP

image

image

Toggle WIP for new PR

image

Update branch by merge/rebase

image

Reference in new issue

image

initRepoIssueComments

Unable to screenshot, see the comment

Show/hide out-dated, comment reply

image

image

Markdown editor in issue template

image

@wxiaoguang wxiaoguang force-pushed the refactor-repo-issue branch from 557aaa8 to 95d60f7 Compare March 4, 2025 10:48
@wxiaoguang wxiaoguang force-pushed the refactor-repo-issue branch from 95d60f7 to a23b342 Compare March 4, 2025 11:14
@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 4, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 4, 2025
delvh
delvh approved these changes Mar 4, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) March 4, 2025 17:19
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@wxiaoguang wxiaoguang merged commit 75e85c2 into go-gitea:main Mar 4, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@wxiaoguang wxiaoguang deleted the refactor-repo-issue branch March 4, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/internal modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @delvh @GiteaBot