Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust appearence of commit status webhook (#33778) #33789

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Adjust appearence of commit status webhook (#33778) #33789

merged 2 commits into from
Mar 4, 2025
+12 −5

Conversation

GiteaBot
Copy link
Collaborator

@GiteaBot GiteaBot commented Mar 4, 2025

Backport #33778 by @denyskon

Some visual improvement for the commit status webhook message introduced by #33320

  • use short commit SHA as already done in e. g. commit webhook
  • fix spacing, link text
  • do not set user link for internal gitea-actions user

Before:
grafik

After:
grafik

@denyskon @GiteaBot
Adjust appearence of commit status webhook (go-gitea#33778)
2ea1ade 
Some visual improvement for the commit status webhook message introduced
by go-gitea#33320

- use short commit SHA as already done in e. g. commit webhook
- fix spacing, link text
- do not set user link for internal gitea-actions user

Before: 

![grafik](https://github.com/user-attachments/assets/9c460846-c350-444c-89b5-8a0d5e26cb86)

After:

![grafik](https://github.com/user-attachments/assets/05519cd8-6d8f-432b-bd9d-082de558a55a)
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code topic/webhooks type/enhancement An improvement of existing functionality labels Mar 4, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 4, 2025
@GiteaBot GiteaBot added this to the 1.23.5 milestone Mar 4, 2025
@GiteaBot GiteaBot requested review from lunny and wxiaoguang March 4, 2025 15:42
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 4, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
@lunny lunny mentioned this pull request Mar 4, 2025
Merged
@lunny lunny merged commit 69d35ee into go-gitea:release/v1.23 Mar 4, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 4, 2025
lunny added a commit that referenced this pull request Mar 4, 2025
@lunny @metiftikci
Add changelog for 1.23.5 (#33780)
9c3511f 
Wait tomorrow's Golang version.
Maybe wait backport of #33764 and #33744, #33789

---------

Co-authored-by: metiftikci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denyskon denyskon denyskon approved these changes

@hiifong hiifong hiifong approved these changes

@lunny lunny Awaiting requested review from lunny

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees

@denyskon denyskon

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/webhooks type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.23.5
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @denyskon @hiifong @lunny