Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.3/glfw: add netbsd support #341

Merged
merged 1 commit into from
Dec 4, 2021
Merged

v3.3/glfw: add netbsd support #341

merged 1 commit into from
Dec 4, 2021

Conversation

ilylily
Copy link
Contributor

@ilylily ilylily commented Nov 28, 2021

just add some missing build tags. helps with #288

should wayland build tags be included even if glfw upstream doesn't support netbsd's input system yet? and if so, should i keep the mention in the readme? either glfw supporting wscons or netbsd supporting evdev would make this build for wayland as is

as an example of updating a wayland application in such a way, Nia Alarie added wscons to swc with a surprisingly small patchset. so i think this would be easier than it might sound at first

just add some missing build tags
Copy link
Collaborator

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks a lot for making it happen.
I think it would be sensible to leave waylaid support out given that it isn't supported upstream. Is there an issue upstream about adding that support?

Copy link
Member

@dmitshur dmitshur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this change looks reasonable, so I'll merge it to move it forward.

I think it's fine both to leave out wayland tags until they're supported, but also okay to include them proactively given the README says the support is incomplete. Having tags in place in advance is maybe less than ideal, but not a big deal. Both options are okay, so let's proceed with it as is for now to save on a review roundtrip, and adjust later as needed.

@dmitshur dmitshur merged commit caad923 into go-gl:master Dec 4, 2021
@Jacalz
Copy link
Collaborator

Jacalz commented Dec 5, 2021

I guess this also requires work over in the gl package?
image

@ilylily
Copy link
Contributor Author

ilylily commented Dec 5, 2021

glow is patched with netbsd support, so gl just needs to be regenerated. you can mess with the instructions in the glow readme to generate the relevant profiles, and vendor them in for testing. not sure who to talk to about updating gl

@Jacalz
Copy link
Collaborator

Jacalz commented Dec 7, 2021

@hajimehoshi Are you perhaps the right one to ask for regenerating gl?

@hajimehoshi
Copy link
Member

Well, however, I'm now pretty busy now. Anyone can regenerate gl and send a PR. Thanks,

@Jacalz
Copy link
Collaborator

Jacalz commented Dec 8, 2021

Well, however, I'm now pretty busy now. Anyone can regenerate gl and send a PR. Thanks,

I was not sure how to do it. Saw the documentation afterwards and did it myself instead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants