temporary fix ci #6825
Closed
temporary fix ci #6825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeidee
approved these changes
Feb 5, 2024
|
Having a broken CI broken is acceptable as long as we haven't released a new version yet. Let's fix the tests for each driver first. |
Any maintainer can merge PRs, this is your right and responsibility ;) I'm fine with it as long as it doesn't break anything and won't be broken in the near future (bad example, introduce new concepts or public APIs without prior discussion) Anyway, if anything is unclear, always good to @ me, and I'll check it out as soon as I have time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
just a temporary fix, when we merge the #6822, this part needs to be rollback.
User Case Description