fix: deterministic index ordering when migrating #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: We observed that, when creating a database based on the same gORM schema multiple times, indexes could appear in different orders, hurting determinism for use-cases like schema comparison. In order to fix this, it's simple to switch the ParseIndexes function to return a list of indices rather than a map, so the callers will iterate in deterministic order.
|
If the maintainers are happy with this, I think it makes sense to do this for ParseUniqueConstraints and ParseCheckConstraints as well. I'm happy to do those as follow-on PRs as well. Just let me know. |
|
The test failure seems like a flake or something (container failed to start). Looks like I don't have permissions to re-run it. |
|
@jinzhu What do you think about this? |
|
I have the same issue - would be good to merge this fix. |
|
Hi @bamo Can you rebase the master branch, it might fix the tests. |
|
@jinzhu done! |
|
Hey @jinzhu, I don't mean to bother you here, just wondering if there's anything else you'd like me to do for this or if you think we can land this soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
Change ParseIndexes to return a list of indices rather than a map, so the callers will iterate in deterministic order. This means when re-creating a database from the same schema, indexes will be created in a consistent order.
User Case Description
Issue: We observed that, when creating a database based on the same gORM schema multiple times, indexes could appear in different orders, hurting determinism for use-cases like schema comparison.