Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add support for LIMIT query in UPDATE for sql/sqlite #452

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Hasaber8
Copy link

@Hasaber8 Hasaber8 commented Feb 8, 2025

Closes #448

@Hasaber8
Copy link
Author

Hasaber8 commented Feb 8, 2025

Fixed the failing tests.

* For multiple-table syntax, ORDER BY and LIMIT cannot be used.
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.24%. Comparing base (00b8155) to head (9103c72).

Files with missing lines Patch % Lines
mysql/update_statement.go 85.71% 1 Missing and 1 partial ⚠️
sqlite/update_statement.go 81.81% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (84.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
- Coverage   91.26%   91.24%   -0.03%     
==========================================
  Files         134      134              
  Lines        7765     7788      +23     
==========================================
+ Hits         7087     7106      +19     
- Misses        509      511       +2     
- Partials      169      171       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIMIT ... for UPDATE statements
1 participant