Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for legacy string tag option behavior #63

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Nov 20, 2024

In v1, the string tag option would stringify bools and strings. Add an option to support this behavior in v2.

@dsnet dsnet force-pushed the stringify-legacy branch 2 times, most recently from 9257691 to 3ee655d Compare November 21, 2024 01:36
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through this!

arshal_default.go Outdated Show resolved Hide resolved
arshal_default.go Show resolved Hide resolved
arshal_default.go Outdated Show resolved Hide resolved
In v1, the `string` tag option would stringify bools and strings.
Add an option to support this behavior in v2.
@dsnet dsnet merged commit 7696f99 into master Nov 24, 2024
8 checks passed
@dsnet dsnet deleted the stringify-legacy branch November 24, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants