Always maintain JSON stack pointer #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used to populate the stack pointer only under the semantics of AllowDuplicateNames(false). The argument made at the time was that the stack pointer becomes imprecise if there are duplicate names and that someone might want to disable duplicate name checks for the sake of performance in which case the logic to maintain the name stack becomes an unnecessary burden if the user does not care about ever retrieving the stack. However, preserving the stack pointer is important for providing good errors and v1 has functionally always operated under AllowDuplicateNames(false) semantics. Thus, in order to preserve good errors in v1, always maintain the name stack needed to produce a JSON pointer.
|
For historical review, here's when we last talked about this behavior: https://youtu.be/Y9Me5UzDYTA?feature=shared&t=370 For the sake of good v1 compatibility, this PR changes course on a decision we have previously made. |
johanbrandhorst
approved these changes
Nov 25, 2024
According to the recorded Meet call, this will make things 5-10% slower if |
mvdan
approved these changes
Nov 26, 2024
dsnet
added a commit
that referenced
this pull request
Dec 8, 2024
In #65, we always populate the JSON pointer stack. Thus, there is no need to use the fallback logic of encoding the missing name with the member index.
dsnet
added a commit
that referenced
this pull request
Dec 8, 2024
In #65, we always populate the JSON pointer stack. Thus, there is no need to use the fallback logic of encoding the missing name with the member index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used to populate the JSON stack pointer only under the semantics of
AllowDuplicateNames(false). The argument made at the time was that the stack pointer becomes imprecise if there are duplicate names and that someone might want to disable duplicate name checks for the sake of performance in which case the logic to maintain the name stack becomes an unnecessary burden if the user does not care about ever retrieving the stack.However, preserving the stack pointer is important for providing good errors and v1 has functionally always operated under
AllowDuplicateNames(true)semantics. Thus, in order to preserve good errors in v1, always maintain the name stack needed to produce a JSON pointer.