Optimize Encoder.WriteValue for object names #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By specifying the isVerbatim flag to names.insertQuoted,
the method can avoid unquoting the name since it knows that
it only needs to strip off the surrounding double quotes.
Performance:
name old speed new speed delta
Testdata/CanadaGeometry/Encode/Value/Buffered 1.12GB/s ± 0% 1.15GB/s ± 3% ~ (p=0.151 n=5+5)
Testdata/CitmCatalog/Encode/Value/Buffered 1.76GB/s ± 0% 1.99GB/s ± 1% +13.19% (p=0.008 n=5+5)
Testdata/GolangSource/Encode/Value/Buffered 793MB/s ± 4% 949MB/s ± 1% +19.68% (p=0.008 n=5+5)
Testdata/StringEscaped/Encode/Value/Buffered 228MB/s ± 1% 229MB/s ± 0% ~ (p=0.421 n=5+5)
Testdata/StringUnicode/Encode/Value/Buffered 983MB/s ± 0% 1014MB/s ± 1% +3.12% (p=0.008 n=5+5)
Testdata/SyntheaFhir/Encode/Value/Buffered 1.39GB/s ± 4% 1.65GB/s ± 1% +18.43% (p=0.008 n=5+5)
Testdata/TwitterStatus/Encode/Value/Buffered 1.03GB/s ± 1% 1.23GB/s ± 0% +19.81% (p=0.008 n=5+5)
dsnet
force-pushed
the
encode-value-verbatim
branch
from
3800200 to
0984d1e
Compare
johanbrandhorst
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying the isVerbatim flag to names.insertQuoted, the method can avoid unquoting the name since it knows that it only needs to strip off the surrounding double quotes.
Performance: