Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for v1 json.Number #74

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Implement support for v1 json.Number #74

merged 1 commit into from
Dec 17, 2024

Conversation

dsnet
Copy link
Collaborator

@dsnet dsnet commented Dec 16, 2024

No description provided.

@dsnet
Copy link
Collaborator Author

dsnet commented Dec 16, 2024

Only 181 failures to go!

mvdan
mvdan approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or move the types to an internal packahe, making the v1 type an alias?

@dsnet
Copy link
Collaborator Author

dsnet commented Dec 17, 2024

Moving as an alias unfortunately loses good documentation for all public methods :/

@dsnet dsnet merged commit e98bb04 into master Dec 17, 2024
8 checks passed
@dsnet dsnet deleted the legacy-number branch December 17, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

@johanbrandhorst johanbrandhorst Awaiting requested review from johanbrandhorst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsnet @mvdan