Avoid recording JSON kind in unmarshal errors before next token #76
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every caller of newUnmarshalErrorBefore is for the case where the Go type has some problem and cannot be unmarshaled into. In such a case, recording the upcoming JSON kind is a red herring since it is information that is not directly relevant to the problem.
|
Before it would print: now it just prints: which is more clear about what the problem is. More information in an error is not always a good thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every caller of newUnmarshalErrorBefore is for the case where the Go type has some problem and cannot be unmarshaled into. In such a case, recording the upcoming JSON kind is a red herring since it is information that is not directly relevant to the problem.