Move diff_test.go to v1 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
force-pushed
the
move-diff-test
branch
from
446a168 to
9f65eca
Compare
The diff_test.go suite of tests check for expected differences between v1 and v2. In some ways, they are higher fidelity tests for v1 behavior than the v1 tests themselves. Modify diff_test.go to use the emulated v1 implementation and skip the tests are currently failing.
dsnet
force-pushed
the
move-diff-test
branch
from
9f65eca to
601ca5c
Compare
mvdan
approved these changes
Dec 22, 2024
| @@ -2,7 +2,7 @@ | |||
| // Use of this source code is governed by a BSD-style | |||
| // license that can be found in the LICENSE file. | |||
|
|
|||
| package json_test | |||
| package json | |||
There was a problem hiding this comment.
I might prefer to use external test packages in general or by default, but I don't hold that strongly.
There was a problem hiding this comment.
Unfortunately, I lose access to the private knownTestFailure function. We can fix this after the work is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff_test.go suite of tests check for expected differences between v1 and v2. In some ways, they are higher fidelity tests for v1 behavior than the v1 tests themselves.
Modify diff_test.go to use the emulated v1 implementation and skip the tests are currently failing.