Support named strings as inlined map keys #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to support map[~string]T as an inlined fallback so long as the string type does not implement marshal/unmarshal methods.
|
@nickkhyl, my apologies for the delay, but I wanted this to go in after a lot of the recent changes for v1 compatibility. I'm not sure how to push directly to your PR (as I think I would need write privileges to your fork). We can either:
Either approach works for me. The commit in this PR has you listed as the author. |
|
Thank you @dsnet for rebasing it for me. The fork is tailscale/json, and I (incorrectly) assumed that our engineers have access to it by default. I'll have that fixed, just in case someone else would like to contribute in the future. In the meantime, I think we should submit this PR since the work has already been done here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to support map[~string]T as an inlined fallback so long as the string type does not implement marshal/unmarshal methods.