Implement legacy support for quoted nulls #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnet
force-pushed
the
legacy-quoted-null
branch
from
f9acf26 to
09400ea
Compare
mvdan
approved these changes
Dec 23, 2024
| // within the pointer value, rather than the indirect value. | ||
| // | ||
| // TODO: This does not handle correctly handle escaped nulls | ||
| // (e.g., "\u006e\u0075\u006c\u006c"), but is good enough |
There was a problem hiding this comment.
I would be really, really surprised if anyone did this...
kortschak
reviewed
Dec 23, 2024
When the `string` option is used, a JSON null quoted within a JSON string is a valid substitute for a JSON null.
dsnet
force-pushed
the
legacy-quoted-null
branch
from
09400ea to
3a8938c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
stringoption is used, a JSON null quoted within a JSON string is a valid substitute for a JSON null.