Make url and http_url work with url.URL.
#1231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodivbyzero
reviewed
Dec 13, 2024
Comment on lines
+1462
to
1466
| if stringer, ok := field.Interface().(fmt.Stringer); ok { | ||
| s = stringer.String() | ||
| } else { | ||
| panic(fmt.Sprintf("Bad field type %T", field.Interface())) | ||
| } |
There was a problem hiding this comment.
Suggested change
| if stringer, ok := field.Interface().(fmt.Stringer); ok { | |
| s = stringer.String() | |
| } else { | |
| panic(fmt.Sprintf("Bad field type %T", field.Interface())) | |
| } | |
| if stringer, ok := field.Interface().(fmt.Stringer); !ok { | |
| panic(fmt.Sprintf("Bad field type %T", field.Interface())) | |
| } | |
| s = stringer.String() | |
nodivbyzero
reviewed
Dec 13, 2024
| return false | ||
| } | ||
| url, err := url.Parse(s) | ||
| if err != nil || url.Scheme == "" { |
There was a problem hiding this comment.
Suggested change
| if err != nil || url.Scheme == "" { | |
| if err != nil { |
nodivbyzero
reviewed
Dec 13, 2024
|
|
||
| return true | ||
| if url.Host == "" && url.Fragment == "" && url.Opaque == "" { |
There was a problem hiding this comment.
Suggested change
| if url.Host == "" && url.Fragment == "" && url.Opaque == "" { | |
| if url.Scheme == "" || (url.Host == "" && url.Fragment == "" && url.Opaque == "") { |
|
I've added a few comments suggesting readability improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
This makes the
urlandhttp_urlvalidations work withurl.URLor any newtype that implements theStringerinterface. I'm not familiar with the codebase so it's kind of a PoC PR to see if you think this can be useful.Make sure that you've checked the boxes below before you submit PR:
But they don't pass, if this is a feature we want and it's the right approach I can investigate deeper. I suspect the reflection magic isn't working as I expected.
@go-playground/validator-maintainers