Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postcode_iso3166_alpha2_field validation #1359

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ddevcap
Copy link
Contributor

@ddevcap ddevcap commented Jan 6, 2025

Fixed an issue where the post codes regexes would not get initialised for postcode_iso3166_alpha2_field validation.

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

Fixed an issue where the post codes regexes would not get initialised for postcode_iso3166_alpha2_field validation.
@ddevcap ddevcap marked this pull request as ready for review January 6, 2025 09:37
@ddevcap ddevcap requested a review from a team as a code owner January 6, 2025 09:37
@coveralls
Copy link

Coverage Status

coverage: 74.319% (+0.001%) from 74.318%
when pulling 7490de4 on ddevcap:master
into 6c3307e on go-playground:master.

Copy link
Contributor

@nodivbyzero nodivbyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nodivbyzero
Copy link
Contributor

I think this fix is connected to #1354

Copy link

@chipaca chipaca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Should we make the tests un-init everything so we catch this kind of bug there?

@nodivbyzero nodivbyzero merged commit b111154 into go-playground:master Feb 3, 2025
15 checks passed
KimNorgaard pushed a commit to KimNorgaard/validator that referenced this pull request Feb 25, 2025
Fixed an issue where the post codes regexes would not get initialised
for postcode_iso3166_alpha2_field validation.

## Fixes Or Enhances


**Make sure that you've checked the boxes below before you submit PR:**
- [x] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants