Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Replace WARC with Obelisk #481

Closed
wants to merge 5 commits into from
Closed

Draft: Replace WARC with Obelisk #481

wants to merge 5 commits into from

Conversation

fmartingr
Copy link
Member

@fmartingr fmartingr commented Sep 30, 2022

This is a draft to replace WARC with Obelisk in order to know what would be the impact of such a change.

Notes:

  • Serving content (not archives) uses the archive in some way. Don't know why, need to investigate
  • Old archives would require a migration from the old system (WARC) to the new one (Obelisk) potentially saving up space and being much more confortable to manage since it will create single files.
  • Right now storage is file-based, I would move things to database with a cache layer so its easier for us to manage and for users to backup, manage and migrate.

Closes #353

@fmartingr fmartingr self-assigned this Sep 30, 2022
@Katarn
Copy link
Contributor

Katarn commented Sep 30, 2022

Right now storage is file-based, I would move things to database with a cache layer so its easier for us to manage and for users to backup, manage and migrate.

I would make this functionality optional. I'm afraid to imagine how large the database dumps will be, they are clearly not intended for such use.

Also it seems that there is not enough setting to indicate in each specific case whether it is necessary to save, for example, JavaScript. The obelisk itself has such an functionality.

@hulb
Copy link
Contributor

hulb commented Oct 14, 2022

Actually I have a need for shiori to save these archive files to object storage like minio :)

@fmartingr
Copy link
Member Author

Actually I have a need for shiori to save these archive files to object storage like minio :)

I believe you already can mount volumes as s3-compatible storage by using docker/k8s?

@Monirzadeh
Copy link
Collaborator

Monirzadeh commented Jan 31, 2024

Just to not forget maybe possibility of download archive file in api can be helpful for this situation.
DesarrolloAntonio/Shiori-Android-Client#4 (comment)

Copy link

stale bot commented Oct 28, 2024

This issue has been automatically marked as stale because it has not had any activity for quite some time.
It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the tag:stale label Oct 28, 2024
@fmartingr fmartingr closed this Nov 1, 2024
@fmartingr fmartingr deleted the feat/obelisk branch November 1, 2024 08:40
@Monirzadeh
Copy link
Collaborator

@fmartingr
why close this? do you send new PR for that?

@fmartingr
Copy link
Member Author

This was very outdated and it has very fee work on it. The PDF archiver refactored most of the logic so I need to start over when that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Obelisk archiving
4 participants