Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proof of concepts: Introduce reader and write groutine #1491

Closed
wants to merge 107 commits into from
Closed

proof of concepts: Introduce reader and write groutine #1491

wants to merge 107 commits into from

Commits on Oct 5, 2023

  1. introduce writer goroutine

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    e4761dd View commit details
    Browse the repository at this point in the history

  2. skip failing tests

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5ec520f View commit details
    Browse the repository at this point in the history

  3. introduce reader loop

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    22dd1e4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into introduce-reader-and-write-groutine-3

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    df63ad7 View commit details
    Browse the repository at this point in the history

  5. skip failing test: TestConnectionAttributes

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    a2f43e6 View commit details
    Browse the repository at this point in the history

  6. fix compile error

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8888cbe View commit details
    Browse the repository at this point in the history

  7. skip failing test

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    62a33a1 View commit details
    Browse the repository at this point in the history

  8. suppress warnings

    @shogo82148
    shogo82148 committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9d248ae View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. introduce mysqlConn.data

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    6629b93 View commit details
    Browse the repository at this point in the history

  2. stop using buffer.takeSmallBuffer

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    f35e499 View commit details
    Browse the repository at this point in the history

  3. stop using buffer.takeCompleteBuffer

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    56fe716 View commit details
    Browse the repository at this point in the history

  4. Revert "introduce mysqlConn.data" 

    This reverts commit 6629b93.
    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    95e59e1 View commit details
    Browse the repository at this point in the history

  5. revert changes of buffer.takeSmallBuffer

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    1b07946 View commit details
    Browse the repository at this point in the history

  6. introduce mysqlConn.data

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    4ffc645 View commit details
    Browse the repository at this point in the history

  7. re-implement mysqlConn.writeCommandPacket

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    dd65116 View commit details
    Browse the repository at this point in the history

  8. re-implement mysqlConn.writeCommandPacketUint32

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    5c4569a View commit details
    Browse the repository at this point in the history

  9. remove buffer.takeSmallBuffer

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    8c475de View commit details
    Browse the repository at this point in the history

  10. remove buffer.store

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b584ce9 View commit details
    Browse the repository at this point in the history

  11. remove buffer.takeBuffer

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    366679e View commit details
    Browse the repository at this point in the history

  12. re-implement mysqlConn.readPacket

    @shogo82148
    shogo82148 committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    525a5a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. fix race condition of read

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    832eeab View commit details
    Browse the repository at this point in the history

  2. mysqlConn.readFull supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    6826f06 View commit details
    Browse the repository at this point in the history

  3. mysqlConn.writePacket now supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5ed7b40 View commit details
    Browse the repository at this point in the history

  4. mysqlConn.readPacket now supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    d1c6fa0 View commit details
    Browse the repository at this point in the history

  5. mysqlCon.handleAuthResult support context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    6b20c77 View commit details
    Browse the repository at this point in the history

  6. mysqlConn.handleInFileRequest supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e62a325 View commit details
    Browse the repository at this point in the history

  7. mysqlConn.readHandshakePacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    525ee4d View commit details
    Browse the repository at this point in the history

  8. mysqlConn.writeHandshakeResponsePacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    20ce0ad View commit details
    Browse the repository at this point in the history

  9. mysqlConn.writeAuthSwitchPacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4274a48 View commit details
    Browse the repository at this point in the history

  10. Revert "mysqlConn.readHandshakePacket supports context" 

    This reverts commit 525ee4d.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    21c54fa View commit details
    Browse the repository at this point in the history

  11. mysqlConn.readHandshakePacket support context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    50e2037 View commit details
    Browse the repository at this point in the history

  12. mysqlConn.writeCommandPacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    956412b View commit details
    Browse the repository at this point in the history

  13. Revert "mysqlConn.readHandshakePacket support context" 

    This reverts commit 50e2037.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9b8f2eb View commit details
    Browse the repository at this point in the history

  14. mysqlConn.writeCommandPacketStr supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c62067a View commit details
    Browse the repository at this point in the history

  15. mysqlConn.writeCommandPacketUint32 supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c9de1fc View commit details
    Browse the repository at this point in the history

  16. mysqlConn.readAuthResult supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8717263 View commit details
    Browse the repository at this point in the history

  17. okHandler.readResultOK supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8f381e1 View commit details
    Browse the repository at this point in the history

  18. okHandler.readResultSetHeaderPacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    13d825d View commit details
    Browse the repository at this point in the history

  19. mysqlConn.readColumns supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e943ca7 View commit details
    Browse the repository at this point in the history

  20. mysqlConn.exec supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4328b11 View commit details
    Browse the repository at this point in the history

  21. re-implement mysqlConn.ExecContext

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    48d12aa View commit details
    Browse the repository at this point in the history

  22. mysqlConn.query and mysqlStmt.query accept context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    f41405c View commit details
    Browse the repository at this point in the history

  23. mysqlStmt.ExecContext propagates context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5868824 View commit details
    Browse the repository at this point in the history

  24. mysqlStmt.writeExecutePacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c4b0b07 View commit details
    Browse the repository at this point in the history

  25. fix: TestConnectorTimeoutsDuringOpen

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    cf055bb View commit details
    Browse the repository at this point in the history

  26. mysqlConn.Ping no longer need to call watchCancel

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9309e5d View commit details
    Browse the repository at this point in the history

  27. mysqlConn.begin supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    57aa3e2 View commit details
    Browse the repository at this point in the history

  28. mysqlConn.PrepareContext propagates context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    952400c View commit details
    Browse the repository at this point in the history

  29. fix compile error

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    62c508a View commit details
    Browse the repository at this point in the history

  30. fix TestCleanCancel

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    17f7abe View commit details
    Browse the repository at this point in the history

  31. NextResultSet treats context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    2f77b54 View commit details
    Browse the repository at this point in the history

  32. textRows.readRow and binaryRows.readRow see context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    bcee9e5 View commit details
    Browse the repository at this point in the history

  33. remove the watcher goroutine

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    3719818 View commit details
    Browse the repository at this point in the history

  34. remove mysqlConn.watching

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    6b8b377 View commit details
    Browse the repository at this point in the history

  35. remove mysqlConn.canceled

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    cd998ef View commit details
    Browse the repository at this point in the history

  36. mysqlConn.handleParams supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    31707d5 View commit details
    Browse the repository at this point in the history

  37. mysqlConn.getSystemVar supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    f61cb1f View commit details
    Browse the repository at this point in the history

  38. mysqlConn.readUntilEOF supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    7e45f92 View commit details
    Browse the repository at this point in the history

  39. mysqlStmt.readPrepareResultPacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c90f82e View commit details
    Browse the repository at this point in the history

  40. okHandler.discardResults supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    7656242 View commit details
    Browse the repository at this point in the history

  41. mysqlRows.Close handles context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    28a813e View commit details
    Browse the repository at this point in the history

  42. mysqlStmt.writeCommandLongData supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    14cedd3 View commit details
    Browse the repository at this point in the history

  43. mysqlConn.sendEncryptedPassword support context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    01726b6 View commit details
    Browse the repository at this point in the history

  44. mysqlConn.readHandshakePacket supports context

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e8d1c24 View commit details
    Browse the repository at this point in the history

  45. close the connection if canceled

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    f7f734a View commit details
    Browse the repository at this point in the history

  46. enable -race option

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    923c82b View commit details
    Browse the repository at this point in the history

  47. -covermode must be "atomic", not "count", when -race is enabled

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    cf9b120 View commit details
    Browse the repository at this point in the history

  48. fix race condition of TestConcurrent

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    f6ba15b View commit details
    Browse the repository at this point in the history

  49. revert changes of noCopy

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    68d06b9 View commit details
    Browse the repository at this point in the history

  50. re-implement BenchmarkInterpolation

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    06c89a5 View commit details
    Browse the repository at this point in the history

  51. re-implement TestInterpolateParams

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c6ef997 View commit details
    Browse the repository at this point in the history

  52. re-implement TestInterpolateParamsJSONRawMessage

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    b867777 View commit details
    Browse the repository at this point in the history

  53. re-implement TestInterpolateParamsTooManyPlaceholders

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8a6efeb View commit details
    Browse the repository at this point in the history

  54. re-implement TestInterpolateParamsPlaceholderInString

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    67efea6 View commit details
    Browse the repository at this point in the history

  55. re-implement TestInterpolateParamsUint64

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    aad3fd6 View commit details
    Browse the repository at this point in the history

  56. re-implement TestCheckNamedValue

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    a4af165 View commit details
    Browse the repository at this point in the history

  57. re-implement TestPingMarkBadConnection and TestPingErrInvalidConn

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    166fc5c View commit details
    Browse the repository at this point in the history

  58. re-implement TestReadPacketSingleByte

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0226235 View commit details
    Browse the repository at this point in the history

  59. re-implement TestReadPacketWrongSequenceID

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1eaf0c0 View commit details
    Browse the repository at this point in the history

  60. re-implement TestReadPacketSplit

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1c6e980 View commit details
    Browse the repository at this point in the history

  61. re-implement TestReadPacketFail

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e849989 View commit details
    Browse the repository at this point in the history

  62. re-implement TestRegression801

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    3ae4b2f View commit details
    Browse the repository at this point in the history

  63. Revert "re-implement TestRegression801" 

    This reverts commit 3ae4b2f.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    198f0bf View commit details
    Browse the repository at this point in the history

  64. introduce packet type

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    15cbe27 View commit details
    Browse the repository at this point in the history

  65. check error

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4a07d42 View commit details
    Browse the repository at this point in the history

  66. Revert "Revert "re-implement TestRegression801"" 

    This reverts commit 198f0bf.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8c82535 View commit details
    Browse the repository at this point in the history

  67. Revert "re-implement TestReadPacketFail" 

    This reverts commit e849989.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    803dd56 View commit details
    Browse the repository at this point in the history

  68. Revert "Revert "re-implement TestReadPacketFail"" 

    This reverts commit 803dd56.
    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    222487f View commit details
    Browse the repository at this point in the history

  69. fix broken tests

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    7095f22 View commit details
    Browse the repository at this point in the history

  70. re-implement mysqlConn.readPacket

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5507c4f View commit details
    Browse the repository at this point in the history

  71. introduce packet pool

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    b969ca3 View commit details
    Browse the repository at this point in the history

  72. fix panic

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e86f580 View commit details
    Browse the repository at this point in the history

  73. fix TestReadPacketFail

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    46ed973 View commit details
    Browse the repository at this point in the history

  74. re-implement TestStaleConnectionChecks

    @shogo82148
    shogo82148 committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9431d87 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2023

  1. put packets to pool

    @shogo82148
    shogo82148 committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    14644a0 View commit details
    Browse the repository at this point in the history

  2. re-use package as buffer

    @shogo82148
    shogo82148 committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    744cd7a View commit details
    Browse the repository at this point in the history

  3. use packet pool for Interpolation

    @shogo82148
    shogo82148 committed Oct 8, 2023
    Configuration menu
    Copy the full SHA
    07a417f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. introduce writeBuffer

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    978f9f3 View commit details
    Browse the repository at this point in the history

  2. introduce readBuffer

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b0945da View commit details
    Browse the repository at this point in the history

  3. fix TestPingMarkBadConnection and TestPingErrInvalidConn

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6d17fea View commit details
    Browse the repository at this point in the history

  4. fix TestReadPacketSingleByte

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    c4f94e2 View commit details
    Browse the repository at this point in the history

  5. fix race conditions

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    b6c7b5d View commit details
    Browse the repository at this point in the history

  6. re-introduce packet pool

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6eda7f8 View commit details
    Browse the repository at this point in the history

  7. fix TestReadPacketSplit

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    2e8bb88 View commit details
    Browse the repository at this point in the history

  8. reduce allocation for interpolateParams

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7019692 View commit details
    Browse the repository at this point in the history

  9. cache allocated buffer

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    aecdebb View commit details
    Browse the repository at this point in the history

  10. check mc.reset

    @shogo82148
    shogo82148 committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5bfa422 View commit details
    Browse the repository at this point in the history