-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(local exec): add ability to skip steps #584
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 79.38% 78.97% -0.41%
==========================================
Files 172 172
Lines 7728 7768 +40
==========================================
Hits 6135 6135
- Misses 1357 1397 +40
Partials 236 236
|
@@ -16,6 +16,7 @@ type Config struct { | |||
Target string | |||
Org string | |||
Repo string | |||
Steps []string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steps []string | |
SkipSteps []string |
Thoughts on making this field more descriptive?
// print steps to be removed to the user | ||
if len(stepsToRemove) > 0 { | ||
for _, stepName := range stepsToRemove { | ||
fmt.Println("skip step: ", stepName) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on moving this inside the loops below as we prune the pipeline?
Added flags for skipping steps:
cli/command/pipeline/exec.go
Lines 137 to 144 in a51e7aa
Works for steps, stages, anchors, yaml templates, nested yaml templates.
cli/action/pipeline/exec.go
Lines 118 to 171 in a51e7aa
Also corrected punctuation for proper display in command help output:
cli/command/pipeline/exec.go
Line 163 in a51e7aa