Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: platform settings #310

Merged
merged 13 commits into from
May 13, 2024
Merged

feat: platform settings #310

merged 13 commits into from
May 13, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Apr 29, 2024

requires go-vela/server# before i can remove the go.mod tweak

@plyr4 plyr4 marked this pull request as ready for review May 13, 2024 18:22
@plyr4 plyr4 requested a review from a team as a code owner May 13, 2024 18:22
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.56%. Comparing base (1cd2e5c) to head (793f7af).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
+ Coverage   89.47%   89.56%   +0.09%     
==========================================
  Files          21       21              
  Lines         817      834      +17     
==========================================
+ Hits          731      747      +16     
- Misses         52       53       +1     
  Partials       34       34              
Files Coverage Δ
vela/admin.go 94.87% <100.00%> (+1.22%) ⬆️
vela/client.go 91.00% <100.00%> (+0.04%) ⬆️
vela/vela.go 85.71% <0.00%> (-14.29%) ⬇️

vela/admin.go Outdated Show resolved Hide resolved
vela/admin.go Outdated Show resolved Hide resolved
@plyr4 plyr4 merged commit 1d75672 into main May 13, 2024
10 of 11 checks passed
@plyr4 plyr4 deleted the feat/platform-settings branch May 13, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants