Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment): set repo on create/update DB funcs #1263

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Feb 28, 2025

We do this for every other nested resource

@ecrupper ecrupper requested a review from a team as a code owner February 28, 2025 18:02
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.60%. Comparing base (257886e) to head (7625c35).

Files with missing lines Patch % Lines
database/deployment/create.go 62.50% 2 Missing and 1 partial ⚠️
database/deployment/update.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1263      +/-   ##
==========================================
- Coverage   56.61%   56.60%   -0.01%     
==========================================
  Files         629      629              
  Lines       35670    35678       +8     
==========================================
+ Hits        20193    20195       +2     
- Misses      14797    14801       +4     
- Partials      680      682       +2     
Files with missing lines Coverage Δ
database/deployment/create.go 75.00% <62.50%> (-10.00%) ⬇️
database/deployment/update.go 75.00% <62.50%> (-10.00%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants