feat(deployment): add deployment table #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 96.12% 96.20% +0.07%
==========================================
Files 67 68 +1
Lines 7229 7370 +141
==========================================
+ Hits 6949 7090 +141
Misses 205 205
Partials 75 75
|
|
release and other merges caused some conflicts, so you'll have to resolve that first |
wass3rw3rk
changed the title
|
also, we will want to add tests in /database |
added 2 commits
December 18, 2023 11:11
KellyMerrick
requested changes
Dec 18, 2023
timhuynh94
previously approved these changes
Dec 19, 2023
wass3rw3rk
requested changes
Dec 19, 2023
ecrupper
requested changes
Dec 21, 2023
wass3rw3rk
requested changes
Dec 21, 2023
wass3rw3rk
approved these changes
Dec 22, 2023
plyr4
reviewed
Dec 22, 2023
| RepoID *int64 `json:"repo_id,omitempty"` | ||
| URL *string `json:"url,omitempty"` | ||
| User *string `json:"user,omitempty"` |
There was a problem hiding this comment.
just curious, why'd we remove User?
There was a problem hiding this comment.
because I added a CreatedBy field instead
ecrupper
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a repo has a lot of deployments historically, viewing them in the UI is cumbersome and slow.
The loading of deployments on the deployments tab in Vela takes a few more seconds to load than the other pages (schedules, secrets, audits...) even when there are no deployments for a repo. This is due to the way deployments are stored and retrieved.
The changes made in this pull request add a new database table so that we can store deployment information instead of having to go to the scm to retrieve them. This (plus the implementation in server) greatly improve the time it takes for the deployments page to load.