refactor: organize msg

go-vela · Feb 2, 2024 · 3afa056 · 3afa056
1 parent 0e8978a
commit 3afa056
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/elm/Shared.elm b/src/elm/Shared.elm
@@ -243,6 +243,14 @@ update route msg model =
             , Effect.none
             )
 
+        -- FAVICON
+        Shared.Msg.UpdateFavicon options ->
+            let
+                ( newFavicon, updateFavicon ) =
+                    Favicons.updateFavicon model.favicon options.favicon
+            in
+            ( { model | favicon = newFavicon }, updateFavicon |> Effect.sendCmd )
+
         -- TIME
         Shared.Msg.AdjustTimeZone options ->
             ( { model | zone = options.zone }
@@ -610,14 +618,6 @@ update route msg model =
                 Interval.FiveSeconds ->
                     ( model, Effect.none )
 
-        -- FAVICON
-        Shared.Msg.UpdateFavicon options ->
-            let
-                ( newFavicon, updateFavicon ) =
-                    Favicons.updateFavicon model.favicon options.favicon
-            in
-            ( { model | favicon = newFavicon }, updateFavicon |> Effect.sendCmd )
-
 
 subscriptions : Route () -> Model -> Sub Msg
 subscriptions _ model =

diff --git a/src/elm/Shared/Msg.elm b/src/elm/Shared/Msg.elm
@@ -29,6 +29,8 @@ type Msg
     | OnKeyDown { key : String }
     | OnKeyUp { key : String }
     | VisibilityChanged { visibility : Browser.Events.Visibility }
+      -- FAVICON
+    | UpdateFavicon { favicon : Favicons.Favicon }
       -- TIME
     | AdjustTimeZone { zone : Time.Zone }
     | AdjustTime { time : Time.Posix }
@@ -60,5 +62,3 @@ type Msg
     | HandleHttpError (Http.Detailed.Error String)
       -- REFRESH
     | Tick { interval : Interval.Interval, time : Time.Posix }
-      -- FAVICON
-    | UpdateFavicon { favicon : Favicons.Favicon }