Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance(deployments): use scm default for target and adjust ref resolution #720

Merged
merged 2 commits into from
Sep 19, 2023
Merged

enhance(deployments): use scm default for target and adjust ref resolution #720

merged 2 commits into from
Sep 19, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper requested a review from a team as a code owner September 14, 2023 16:50
plyr4
plyr4 previously approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

KellyMerrick
KellyMerrick approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit b406316 into main Sep 19, 2023
12 checks passed
@ecrupper ecrupper deleted the enhance/deployments/use-scm-default branch September 19, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@plyr4 plyr4 plyr4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ecrupper @KellyMerrick @plyr4 @wass3rw3rk