Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(build): logic parsing and linking of auto cancel messaging #730

Merged
merged 12 commits into from
Nov 1, 2023

Conversation

ecrupper
Copy link
Contributor

Types / Server PRs: go-vela/types#299 & go-vela/server#911

UI essentially determines whether a build was canceled or auto-canceled based on the content of the error message and then links the superseding build in the message itself.

Will update description with styling decisions when made and bring the PR out of draft at that point.

docker-compose.yml Outdated Show resolved Hide resolved
@ecrupper ecrupper marked this pull request as ready for review November 1, 2023 15:49
@ecrupper ecrupper requested a review from a team as a code owner November 1, 2023 15:49
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels like cheating but I happen to approve :) nice work.

Copy link
Contributor

@claire1618 claire1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me!

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@ecrupper ecrupper merged commit 607d327 into main Nov 1, 2023
12 checks passed
@ecrupper ecrupper deleted the hackathon-auto-cancel branch November 1, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants