Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): address a11y issues and enable tests #733

Merged
merged 41 commits into from
Nov 2, 2023

Conversation

claire1618
Copy link
Contributor

@claire1618 claire1618 commented Oct 30, 2023

Making a few small changes to make Vela more accessible on a variety of fronts, updating code to meet the accessibility requirements that are tested for with the Cyprus a11y tests.

A lot of the work was changing the role or label in a certain element to make it easier for people using screen readers to navigate.

There were also some small tweaks to the colors of the page to give a higher contrast, making the site easier for people with visual impairments to navigate the site.

@claire1618 claire1618 requested a review from a team as a code owner October 30, 2023 19:33
Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spotted a few things. excited to get these tests going again - thanks!

cypress/integration/a11y.lighttheme.spec.js Outdated Show resolved Hide resolved
cypress/support/commands.js Outdated Show resolved Hide resolved
src/elm/Pages/Build/View.elm Outdated Show resolved Hide resolved
src/elm/Pages/Build/View.elm Outdated Show resolved Hide resolved
src/elm/Pages/Build/View.elm Outdated Show resolved Hide resolved
src/scss/_main.scss Outdated Show resolved Hide resolved
src/scss/_themes.scss Outdated Show resolved Hide resolved
src/scss/_themes.scss Outdated Show resolved Hide resolved
src/scss/_main.scss Outdated Show resolved Hide resolved
src/scss/_main.scss Outdated Show resolved Hide resolved
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️ lgtm

@wass3r wass3r changed the title enhance: UI Accessibility improvements fix(a11y): address a11y issue and enable tests Nov 1, 2023
@wass3r wass3r changed the title fix(a11y): address a11y issue and enable tests fix(a11y): address a11y issues and enable tests Nov 1, 2023

it.skip('overview', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ finally enabled

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work

@claire1618 claire1618 merged commit b155c3a into main Nov 2, 2023
12 checks passed
@claire1618 claire1618 deleted the enhance/accessibility branch November 2, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants