-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): address a11y issues and enable tests #733
Conversation
…a/ui into enhance/scheduledBuildBranches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spotted a few things. excited to get these tests going again - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you ❤️ lgtm
|
||
it.skip('overview', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ finally enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work
Making a few small changes to make Vela more accessible on a variety of fronts, updating code to meet the accessibility requirements that are tested for with the Cyprus a11y tests.
A lot of the work was changing the role or label in a certain element to make it easier for people using screen readers to navigate.
There were also some small tweaks to the colors of the page to give a higher contrast, making the site easier for people with visual impairments to navigate the site.