Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: elm rebuild #761

Merged
merged 211 commits into from
Mar 25, 2024
Merged

refactor: elm rebuild #761

merged 211 commits into from
Mar 25, 2024

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jan 31, 2024 •
edited
Loading

this PR includes all of the changes mentioned in PR #752:

refactoring the code to follow established patterns better, inspired by elm-land and NextJS

the main idea is to build the app around the following core components

  • Shared
  • Layouts
  • Pages
  • View
  • Components
  • Auth

some other welcome changes that are included:

  • /add-deployment is now /deployments/add (consistency)
  • /add-schedule is now /schedules/add (consistency)
  • /deployments/add supports query parameters

KellyMerrick and others added 30 commits December 27, 2023 15:56
@KellyMerrick
refactor(elm): created Shared model
8d26ab6
@plyr4
chore: elm-format
9bb887d
@plyr4
chore: refactor toasties
ba318a8
@plyr4
chore: remove repo
d181af0
@KellyMerrick
refactor(elm): refactored user using shared model
6ef7c53
@KellyMerrick
refactor(elm): refactored sourceRepos using shared model
f4e6dce
@KellyMerrick
refactor(elm): refactored time using shared model
88f4189
@KellyMerrick
refactor(elm): refactored entryURL using shared model
a9d9549
@KellyMerrick
refactor(elm): refactored visibility using shared model
e483ba0
@KellyMerrick
refactor(elm): refactored buildMenuOpen using shared model
23cf225
@plyr4
refactor(elm): refactored pipeline using shared model
b74c369
@plyr4
refactor(elm): refactored templates using shared model
8128c6d
@plyr4
refactor(elm): exposing only model
2bf109e
@plyr4
refactor(elm): todo comments and use Shared.Flags
f57fece
@plyr4
refactor(elm): prepare for Msg and more todo comments
876fa65
@plyr4
refactor: starting to deal with Effect, Pages, and tons of Msg
d6f728b
@KellyMerrick
refactor(elm): starting to populate new home page
42007f3
@plyr4
refactor: split Api.elm to fix cycle import with refactored msg flow
230765d
@plyr4
refactor: rename page to legacyPage, rename pageModel to page, reorde…
95ba8bf 
…r Model to match elm-land
@plyr4
refactor: make init look like elm-land init
be1c083
@plyr4
refactor: organized Main.elm into sections of keep then remove
acc4ff0
@plyr4
refactor: tons of main.elm organization, layouts, auth, and login code
daecf39
@plyr4
refactor: auth working, tons of comments, needs cleanup
a8b3e12
@plyr4
refactor: cleaning up auth code and moving things to shared.msg
f7cc6de
@plyr4
refactor: moved clipboard copy alert to shared.msg
2c88b43
@plyr4
refactor: adding Authenticate page
6d2f97e
@plyr4
refactor: fixed auth/login flow, implemented most of source repos
47b7018
@plyr4
refactor: dynamic route, and functioning default layout, work in prog…
f2e3d40 
…ress
@plyr4
refactor: components for the default layout, layout and component props
3e0047a
@plyr4
refactor: rename Login_ model to AccountLogin_
f2a2b44
ecrupper
ecrupper previously approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

wass3rw3rk
wass3rw3rk previously approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 a new beginning! mammoth effort and nice work! GitHub UI diff view choked a little bit here and there 😓 walked through in local stack and everything looked and worked great.

i did point some minor things out, but happy to address in a follow-up(s).

ecrupper
ecrupper previously approved these changes Mar 21, 2024
View reviewed changes
wass3rw3rk
wass3rw3rk previously approved these changes Mar 21, 2024
View reviewed changes
@plyr4 plyr4 dismissed stale reviews from wass3rw3rk and ecrupper via 9c22aab March 25, 2024 13:43
KellyMerrick
KellyMerrick approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 0676888 into main Mar 25, 2024
13 checks passed
@plyr4 plyr4 deleted the refactor/elm-rebuild branch March 25, 2024 15:17
@plyr4 plyr4 mentioned this pull request Mar 26, 2024
Open
@plyr4 plyr4 mentioned this pull request Sep 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KellyMerrick KellyMerrick KellyMerrick approved these changes

@ecrupper ecrupper ecrupper approved these changes

@wass3rw3rk wass3rw3rk wass3rw3rk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@plyr4 @KellyMerrick @wass3rw3rk @ecrupper