chore(linter): fix linter errors, remove deprecated allow leading spa…

…ces (#56)

* chore(linter): fix linter errors, remove deprecated allow leading spaces

* chore(codeql): remove toolchain in go.mod to pass

.golangci.yml

@@ -43,7 +43,6 @@ linters-settings:
 
   # https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/nolintlint
   nolintlint:
-    allow-leading-space: true     # allow non-"machine-readable" format (ie. with leading space) 
     allow-unused: false           # allow nolint directives that don't address a linting issue
     require-explanation: true     # require an explanation for nolint directives
     require-specific: true        # require nolint directives to be specific about which linter is being skipped

cmd/vela-email/loginauth.go

@@ -26,7 +26,7 @@ func LoginAuth(username, password string) smtp.Auth {
 // that the authentication should be skipped.
 // If it returns a non-nil error, the SMTP client aborts
 // the authentication attempt and closes the connection.
-func (a *loginAuth) Start(server *smtp.ServerInfo) (string, []byte, error) {
+func (a *loginAuth) Start(_ *smtp.ServerInfo) (string, []byte, error) {
 	return "LOGIN", []byte{}, nil
 }
 

go.mod

@@ -2,8 +2,6 @@ module github.com/go-vela/vela-email
 
 go 1.21
 
-toolchain go1.21.4
-
 require (
 	github.com/Masterminds/semver/v3 v3.2.1
 	github.com/aymerick/douceur v0.2.0