Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move UtfEnumerator from Dalamud to Lumina #2111

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Move UtfEnumerator from Dalamud to Lumina #2111

merged 2 commits into from
Nov 20, 2024

Conversation

Soreepeong
Copy link
Contributor

Comes with some trivial cleanups.

@Soreepeong Soreepeong requested a review from a team as a code owner November 20, 2024 04:52
@Soreepeong
Copy link
Contributor Author

Once NotAdam/Lumina#100 is in, use LSeStringBuilder.GetViewAsSpan() instead of LSeStringBuilder.ToArray().NullTerminate().

@KazWolfe
Copy link
Member

Can you bump to Lumina 5.5.0 and add those changes as well?

Thanks!

@Soreepeong Soreepeong force-pushed the fix/use-lumina-utfenumerator branch from 0263b99 to 8aec82b Compare November 20, 2024 16:49
@Soreepeong
Copy link
Contributor Author

Done, but not tested the actual changes yet; will do in a few hours.

@Soreepeong Soreepeong marked this pull request as draft November 20, 2024 16:50
@Soreepeong
Copy link
Contributor Author

Just confirmed that it works, at least for me.

@Soreepeong Soreepeong marked this pull request as ready for review November 20, 2024 17:32
@KazWolfe KazWolfe enabled auto-merge (squash) November 20, 2024 17:32
@KazWolfe KazWolfe merged commit d19b7d7 into goatcorp:master Nov 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazWolfe KazWolfe KazWolfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soreepeong @KazWolfe