Update the build instructions #335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achow101
reviewed
Oct 22, 2017
README.md
Outdated
| @@ -58,7 +62,11 @@ Multi-signature transactions are accommodated under-the-hood about 80%, and will | |||
| Windows: [Download](http://www.py2exe.org/) | |||
|
|
|||
| * LMDB - database engine, modified to suit Armory's use cases | |||
| [LMDB page](http://symas.com/mdb/) | |||
| Linux: Install package `liblmdb-dev` and `python-lmdb` | |||
There was a problem hiding this comment.
These packages are provided as part of the source code here and have custom modifcation.
There was a problem hiding this comment.
Hmm. In ./cppForSwig/lmdb I guess? Then the README should not mention lmdb as a dependency, correct?
There was a problem hiding this comment.
IMO it should be listed as a dependency without a link and a note that it is provided as part of the source code. Same with cryptopp above.
achow101
reviewed
Oct 22, 2017
README.md
Outdated
| Windows: [LMDB page](http://symas.com/mdb/) | ||
|
|
||
| * FastCGI | ||
| Linux: Install package `libfcgi-dev` |
There was a problem hiding this comment.
This package is distributed as part of the source code as a git submodule. It has custom modifcation.
There was a problem hiding this comment.
As mentioned elsewhere, it didn't actually get included in the distribution tarball.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of dependencies for this package appears to be incomplete. This updates the list.
I note that configure.ac does not check for these dependencies; one trips over them randomly, during the compile stage.