-
-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/integrations: add The Lounge #11971
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Brünen <[email protected]>
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for authentik-storybook canceled.
|
I believe this is not caused by my PR, since the broken links appear to be from somewhere else. |
Hi @OddMagnet thanks for this contribution, and apologies for my slow reply! For the formatting and linting, have you tried running |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11971 +/- ##
==========================================
- Coverage 92.64% 92.61% -0.03%
==========================================
Files 761 761
Lines 37816 37929 +113
==========================================
+ Hits 35033 35127 +94
- Misses 2783 2802 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Hey @tanberry I tried running results❯ npm run prettier npm error Missing script: "prettier" npm error npm error To see a list of scripts, run: npm error npm run npm error A complete log of this run can be found in: /Users/michael/.npm/_logs/2024-11-20T13_08_18_604Z-debug-0.logI went back to look at the problems and looked up I also noticed that the formatting for the "Note" section was off by a bit and I forgot to add the integration to Let me know when I can push the changed |
Great news, thanks for doing that @OddMagnet! Sure, after you have run |
Done |
Had the capitalisation of the folder name wrong initially, seems that change didn't make it into my commits, even though everything ran fine locally. Should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few edits, and the last sentence needs completing, then let's get it merged!
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Michael Brünen <[email protected]>
Co-authored-by: Tana M Berry <[email protected]> Signed-off-by: Michael Brünen <[email protected]>
Signed-off-by: Michael Brünen <[email protected]>
Details
I just finished setting up LDAP for The Lounge and since there was no Integration Guide yet I figured I'd create one.
I'm very new to Authentik and LDAP, so this guide might need some help/refinement.
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)Problems:
I tried running
make website-watch
, but I get this error:make website
also gives me an errorSince this is just a markdown file I suppose these commands might not be necessary to complete on my system.
The
make web
mentioned in the checklist worked.