Add abstract interface to Invariant
#1668
Draft
+63
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sim642
added
cleanup
sim642
commented
Jan 31, 2025
| (* Collect all start states that may satisfy the invariant of current_c *) | ||
| List.iter (fun c -> | ||
| let x = R.ask_local (c.node, c.context) ~local:c.state (Queries.EvalInt c_inv) in | ||
| let x = R.ask_local (c.node, c.context) ~local:c.state (Queries.EvalInt c_inv) in (* TODO: illegal query *) |
There was a problem hiding this comment.
The generation of our proposed precondition loop invariants performs EvalInt queries with witness invariants, assuming they have implicit casts, etc like expressions from the program.
This would no longer be the case with #1665.
So we have to decide what to do here:
- If we don't want to pursue precondition loop invariants and keep them, they could be removed, avoiding the issue.
- Otherwise,
Invariant.tmight need to be turned into a pair of CIL expressions (with and without implicit casts) behind the abstraction. This might be desirable in the long run for Linear Two Variable Equality Domain Refining Value Domain #1635, although that uses separate expression construction frominvariantanyway.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the intended abstract interface to clarify that "Invariants for witnesses" are not just CIL expressions: #1665 (comment).
TODO
WitnessUtil.InvariantExpwork onInvariant.tinstead ofexpfor full type-safety?