Merge pull request #33 from gobuffalo/fix-missing-quote-memory-issue

Out of memory on missing quote fixes #31
gobuffalo · Jan 9, 2018 · 3d4efd2 · 3d4efd2
2 parents 586a6d1 + 7321efa
commit 3d4efd2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lexer/lexer.go b/lexer/lexer.go
@@ -250,7 +250,7 @@ func (l *Lexer) readNumber() string {
 
 func (l *Lexer) readString() string {
 	position := l.position + 1
-	for {
+	for l.ch != 0 {
 		l.readChar()
 		// check for quote escapes
 		if l.ch == '\\' && l.peekChar() == '"' {

diff --git a/plush_test.go b/plush_test.go
@@ -448,6 +448,15 @@ func Test_LineNumberErrors_InsideForLoop(t *testing.T) {
 	r.Contains(err.Error(), "line 3:")
 }
 
+func Test_MissingQuote(t *testing.T) {
+	r := require.New(t)
+	input := `<%= foo("asdf) %>`
+	ctx := NewContext()
+	ctx.Set("foo", func(string) {})
+	_, err := Render(input, ctx)
+	r.Error(err)
+}
+
 func Test_RunScript(t *testing.T) {
 	r := require.New(t)
 	bb := &bytes.Buffer{}