fix DumpSchema for MySQL and CockroachDB #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysqldump would previously try to connect through a Unix socket if the host (-h) flag was given as "localhost". This change forces a TCP connection. Connecting through a Unix socket is still supported. cockroach sql would previously always connect on the default port. This change uses the actual DSN information to dump the schema.
aeneasr
approved these changes
Feb 28, 2024
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 45+7 days with no activity. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqldumpwould previously try to connect through a Unix socket if the host (-h) flag was given aslocalhost. This change forces a TCP connection. Connecting through a Unix socket is still supported.cockroach sqlwould previously always connect on the default port. This change uses the actual DSN information to dump the schema. I've also removed the useless comments from the output.