Merge pull request #341 from gocardless/danw/i-dont-want-to-install-m…

…ysql-so-run-my-tests-here

Test after_commit transactional integrity.

CHANGELOG.md

@@ -1,3 +1,9 @@
+## v4.0.0, 22 February 2019
+
+- Forces Statesman to use a new transactions with `requires_new: true` (https://github.com/gocardless/statesman/pull/249)
+- Fixes an issue with `after_commit` transition blocks that where being
+    executed even if the transaction rolled back. ([patch](https://github.com/gocardless/statesman/pull/338) by [@matid](https://github.com/matid))
+
 ## v3.5.0, 2 November 2018
 
 - Expose `most_recent_transition_join` - ActiveRecords `or` requires that both

lib/statesman/version.rb

@@ -1,3 +1,3 @@
 module Statesman
-  VERSION = "3.5.0".freeze
+  VERSION = "4.0.0".freeze
 end

spec/statesman/adapters/active_record_queries_spec.rb

@@ -168,4 +168,38 @@ def self.transition_class
       end
     end
   end
+
+  context "after_commit transactional integrity" do
+    before do
+      MyStateMachine.class_eval do
+        cattr_accessor(:after_commit_callback_executed) { false }
+
+        after_transition(from: :initial, to: :succeeded, after_commit: true) do
+          # This leaks state in a testable way if transactional integrity is broken.
+          MyStateMachine.after_commit_callback_executed = true
+        end
+      end
+    end
+
+    after do
+      MyStateMachine.class_eval do
+        callbacks[:after_commit] = []
+      end
+    end
+
+    let!(:model) do
+      MyActiveRecordModel.create
+    end
+
+    # rubocop:disable RSpec/ExampleLength
+    it do
+      expect do
+        ActiveRecord::Base.transaction do
+          model.state_machine.transition_to!(:succeeded)
+          raise ActiveRecord::Rollback
+        end
+      end.to_not change(MyStateMachine, :after_commit_callback_executed)
+    end
+    # rubocop:enable RSpec/ExampleLength
+  end
 end