Skip to content

Commit

Permalink
Merge pull request #36 from goccy/fix-error-handling
Browse files Browse the repository at this point in the history
Fix error handling
  • Loading branch information
goccy authored Sep 2, 2022
2 parents 9e100b4 + cf7155d commit 58c858a
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/go-playground/validator/v10 v10.11.0
github.com/goccy/go-yaml v1.9.5
github.com/goccy/go-zetasql v0.3.3
github.com/goccy/go-zetasqlite v0.6.4
github.com/goccy/go-zetasqlite v0.6.5
github.com/google/go-cmp v0.5.8
github.com/gorilla/mux v1.8.0
github.com/jessevdk/go-flags v1.5.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ github.com/goccy/go-yaml v1.9.5 h1:Eh/+3uk9kLxG4koCX6lRMAPS1OaMSAi+FJcya0INdB0=
github.com/goccy/go-yaml v1.9.5/go.mod h1:U/jl18uSupI5rdI2jmuCswEA2htH9eXfferR3KfscvA=
github.com/goccy/go-zetasql v0.3.3 h1:+Ar/GZ4k2vNgaljRPt5lpD8JSIiq0WSEG38Fbowj5fM=
github.com/goccy/go-zetasql v0.3.3/go.mod h1:6W14CJVKh7crrSPyj6NPk4c49L2NWnxvyDLsRkOm4BI=
github.com/goccy/go-zetasqlite v0.6.4 h1:9/ZFuez4Y7Ab22EzWWjsOalRlpufuawPik0o7Xz9eys=
github.com/goccy/go-zetasqlite v0.6.4/go.mod h1:MtofKGFJKkFlxQ10QnJRq51axsbGWnLG06cx4nQVAoY=
github.com/goccy/go-zetasqlite v0.6.5 h1:rdPhsu0350Q1xyi299JRqZ8renUADqoRNBAheBGkKZM=
github.com/goccy/go-zetasqlite v0.6.5/go.mod h1:MtofKGFJKkFlxQ10QnJRq51axsbGWnLG06cx4nQVAoY=
github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b/go.mod h1:SBH7ygxi8pfUlaOkMMuAQtPIUF8ecWP5IEl/CR7VP2Q=
github.com/golang/groupcache v0.0.0-20190702054246-869f871628b6/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
github.com/golang/groupcache v0.0.0-20191227052852-215e87163ea7/go.mod h1:cIg4eruTrX1D+g88fzRXU5OdNfaM+9IcxsU14FzY7Hc=
Expand Down
3 changes: 3 additions & 0 deletions internal/contentdata/repository.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ func (r *Repository) Query(ctx context.Context, tx *connection.Tx, projectID, da
F: cells,
})
}
if err := rows.Err(); err != nil {
return nil, err
}
logger.Logger(ctx).Debug("query result", zap.Any("rows", result))
return &internaltypes.QueryResponse{
Schema: &bigqueryv2.TableSchema{
Expand Down

0 comments on commit 58c858a

Please sign in to comment.