Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter to hide Membership Settings for Access Plans #2831

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

andrewlimaza
Copy link

@andrewlimaza andrewlimaza commented Dec 13, 2024

  • ENHANCEMENT: Added the filter llms_show_membership_settings_for_access_plans to allow developers and integrations to hide this option if they override the membership plans or prevent course editors from adjusting the membership setting for the plan.

This will help us hide this option for Paid Memberships Pro & LifterLMS in streamline mode - strangerstudios/paid-memberships-pro#3088

How has this been tested?

Tested with the following filter call and shows that the section is hidden.
add_filter( 'llms_show_membership_settings_for_access_plans', '__return_false' );

Screenshots

Screenshot 2024-12-13 at 14 17 35

Types of changes

New feature - filter added.

Checklist:

  • This PR requires and contains at least one changelog file.
  • My code has been tested.
  • My code passes all existing automated tests.
  • My code follows the LifterLMS Coding & Documentation Standards.

dependabot bot and others added 2 commits December 11, 2024 08:53
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.4 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.4...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@brianhogg brianhogg changed the base branch from trunk to dev December 16, 2024 15:11
@brianhogg brianhogg added this to the Next Available Release milestone Dec 16, 2024
@brianhogg
Copy link
Contributor

We should add a changelog here, though for a new dev only filter I don't think it's strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

2 participants