Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: perform go path repo move #585

Merged
merged 1 commit into from
Nov 4, 2024
Merged

feat: perform go path repo move #585

merged 1 commit into from
Nov 4, 2024

Conversation

bernhardreiter
Copy link
Member

  • Change the go module path from github.com/csaf-poc/csaf_distribution to github.com/gocsaf/csaf.
  • Rename archive for release tarballs.
  • Adjust testing scripts and documentation.

Does the first steps for #579

@bernhardreiter
feat: perform go path repo move
50959ba 
 * Change the go module path
   from github.com/csaf-poc/csaf_distribution to github.com/gocsaf/csaf.
 * Rename archive for release tarballs.
 * Adjust testing scripts and documentation.
@thiha-min-thant thiha-min-thant mentioned this pull request Oct 31, 2024
Closed
@miklezzzz miklezzzz mentioned this pull request Oct 31, 2024
Closed
2 tasks
koplas
koplas approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@koplas koplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhay-krishna abhay-krishna mentioned this pull request Oct 31, 2024
Open
s-l-teichmann
s-l-teichmann approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@s-l-teichmann s-l-teichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernhardreiter bernhardreiter requested a review from koplas November 4, 2024 09:43
koplas
koplas approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@koplas koplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bernhardreiter
Copy link
Member Author

bernhardreiter commented Nov 4, 2024 •
edited
Loading

@koplas once you have write access, can you also do a practical test (and then write "works" in the review). You should be able to use the branch and revision in the go get to get the new path.

@koplas
Copy link
Contributor

koplas commented Nov 4, 2024 •
edited
Loading

@koplas once you have write access, can you also do a practical test (and then write "works" in the review). You should be able to use the branch and revision in the go get to get the new path.

Running go get github.com/gocsaf/csaf@repomove1 results in the following error:

go: github.com/gocsaf/csaf@repomove1: github.com/gocsaf/[email protected]: invalid version: go.mod has post-v1 module path "github.com/gocsaf/csaf/v3" at revision 50959ba2b338

Update: Running go get github.com/gocsaf/csaf/v3@repomove1 and make dist works.

@koplas koplas merged commit e8706e5 into main Nov 4, 2024
6 checks passed
@bernhardreiter bernhardreiter deleted the repomove1 branch November 4, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koplas koplas koplas approved these changes

@s-l-teichmann s-l-teichmann s-l-teichmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bernhardreiter @koplas @s-l-teichmann