Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.13.1 #699

Closed
wants to merge 17 commits into from
Closed

Release v5.13.1 #699

wants to merge 17 commits into from

Conversation

nmolham-godaddy
Copy link
Contributor

No description provided.

@nmolham-godaddy nmolham-godaddy added the Release Base branch for a new release label Aug 22, 2024
@nmolham-godaddy nmolham-godaddy self-assigned this Aug 22, 2024
@nmolham-godaddy nmolham-godaddy mentioned this pull request Aug 22, 2024
3 tasks
nmolham-godaddy and others added 2 commits August 23, 2024 11:37
* Define IsSingletonTrait

* Add IsSingletonTrait methods

* Unit test IsSingletonTrait

* Add changelog entry

* Check if trait exists rather than class

---------

Co-authored-by: Ashley Gibson <[email protected]>
@agibson-godaddy agibson-godaddy mentioned this pull request Aug 23, 2024
3 tasks
@nmolham-godaddy nmolham-godaddy mentioned this pull request Aug 26, 2024
6 tasks
@agibson-godaddy
Copy link
Contributor

I think we should change this to a minor release: 5.14.0.

We've added several new classes/traits, so minor might be more appropriate than patch.

@nmolham-godaddy
Copy link
Contributor Author

I agree, I created a new release PR for that #705
So we can close this PR

@nmolham-godaddy nmolham-godaddy added the Blocked A pull request tagged as blocked shouldn't be merged until blockers are resolved label Aug 29, 2024
@nmolham-godaddy nmolham-godaddy deleted the release/5.13.1 branch August 30, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked A pull request tagged as blocked shouldn't be merged until blockers are resolved Release Base branch for a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants